STM32WB0x: Add PM support (suspend-to-ram) #94402

HoZHel · 2025-08-12T12:32:05Z

Provide PM support, specifically suspend-to-ram.

Add PM support to the Bluetooth HCI driver.

Optimize power consumption for the Nucleo-WB09KE board.

Provide radio timer driver for STM32WB0x SoCs to be used as the system timer when Bluetooth and/or PM are enabled.

Set the appropriate value for SYS_CLOCK_HW_CYCLES_PER_SEC and
SYS_CLOCK_TICKS_PER_SEC when radio timer is used as the system timer.

Enable UART wake-up line in STM32 driver.

Fix the improper use of CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC for some
STM32WB0 drivers due to the misunderstanding of its definition.

Update west to point to the recent changes for hal_stm32.

Supplementary PR #303.

@mathieuchopstm, thank you for your support in PM.

Fix the improper use of CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC for some STM32WB0 drivers due to the misunderstanding of its definition. Signed-off-by: Ali Hozhabri <[email protected]>

Provide radio timer driver for STM32WB0x SoCs. Signed-off-by: Ali Hozhabri <[email protected]>

Use radio timer as the system timer when Bluetooth is used. Modify CMakeLists.txt to compile radio timer driver when STM32_RADIO_TIMER is enabled. Remove the common parts from hci_stm32wb0.c that are present in the radio timer driver. Set the appropriate value for SYS_CLOCK_HW_CYCLES_PER_SEC and SYS_CLOCK_TICKS_PER_SEC. Signed-off-by: Ali Hozhabri <[email protected]>

Provide PM support, specifically suspend-to-ram, for STM32WB0x. Enable STM32_RADIO_TIMER Kconfig parameter when PM is set. Signed-off-by: Ali Hozhabri <[email protected]>

Enable UART wake-up line in STM32 driver. Signed-off-by: Ali Hozhabri <[email protected]>

Add PM support to the STM32WB0x Bluetooth HCI driver. Implement PM event register to wake up the device for its BLE events. Signed-off-by: Ali Hozhabri <[email protected]>

Optimize power consumption for the Nucleo-WB09KE board by implementing correct pull-up/pull-down configurations when the device enters lower power states. Signed-off-by: Ali Hozhabri <[email protected]>

nordicjm · 2025-08-12T12:42:13Z

soc/st/stm32/stm32wb0x/Kconfig.defconfig

+config SYS_CLOCK_HW_CYCLES_PER_SEC
+	default 409600
+	depends on STM32_RADIO_TIMER


get this from a dts

This is a software timer and there is no crystal running at this frequency that's why it is set in Kconfig. What do you think now?

hardware timer with software configurability? That can be represented in dts, it's going through a hardware block

Let me explain more:
SYS_CLOCK_HW_CYCLES_PER_SEC=409600 is the system time unit (STU). One STU is equal to 625/256 μs (about 2.4414 μs). It is independent to the hardware oscillator variation. Every timeout event is expressed in STU. Only before programming the real counter, the time expressed in STU is converted to the hardware timer counting unit internally from the radio timer driver.
Do you still think that it should be defined in a DTS file?

so then the radio timer driver is wrong? This value should be the hardware cycles per second, as the name implies, there shouldn't be some software translation in a radio driver that changes this into the actual value that the hardware uses, it should be using the hardware value directly

If we use the LSE (low-speed external 32.768 kHz), the SYS_CLOCK_HW_CYCLES_PER_SEC can be calculated and is well known. However, when using the LSI (low-speed internal), this value varies because the clock frequency is unknown and differs between devices within a certain range. In our Bluetooth protocol implementation, it is easier to use the STU, which is fixed and independent of both LSI and LSE. We manage internally this value according to the different HW configuration.

JarmouniA · 2025-08-12T12:49:32Z

boards/st/nucleo_wb09ke/board.c

+	return 0;
+}
+
+SYS_INIT(board_pupd_init, PRE_KERNEL_2, CONFIG_KERNEL_INIT_PRIORITY_DEFAULT);


use

zephyr/include/zephyr/platform/hooks.h

Line 70 in 965bcd6

void board_early_init_hook(void);

instead.
Also, this should be in the SoC hook.

Why should it be in the SoC hook? Would you please explain more?

The operations performed appear to not be board specific.

No. These power pull-up/pull-down configurations are board specific.

JarmouniA · 2025-08-12T12:56:07Z

drivers/bluetooth/hci/hci_stm32wb0.c

-static struct k_work_delayable hal_radio_timer_work, ble_stack_work;
+static struct k_work_delayable ble_stack_work;
+
+#if CONFIG_PM_DEVICE


Suggested change

#if CONFIG_PM_DEVICE

#ifdef CONFIG_PM_DEVICE

apply everywhere for Kconfig symbols

Which style do you suggest? #ifdef or #if defined()?

Which style do you suggest? #ifdef or #if defined()?

either is fine.

JarmouniA · 2025-08-12T13:19:15Z

drivers/serial/uart_stm32.c

+#elif defined(IS_UART_WAKEUP_FROMSTOP_INSTANCE)
+	if (wakeup_line != STM32_WAKEUP_LINE_NONE) {
+		/* Enable EXTI line associated to UART wake-up event */
+		LL_EXTI_EnableIT_0_31(BIT(wakeup_line));


use the STM32 EXTI API in include/zephyr/drivers/interrupt_controller/intc_exti_stm32.h

soc/st/stm32/stm32wb0x/Kconfig.defconfig

JarmouniA · 2025-08-12T13:27:27Z

soc/st/stm32/stm32wb0x/power.c

+ * Things that need to be preserved across Deepstop, but
+ * have no associated driver to backup and restore them.
+ */
+#define SRAM		DT_CHOSEN(zephyr_sram)


Suggested change

#define SRAM DT_CHOSEN(zephyr_sram)

#define STM32WB0_SRAM DT_CHOSEN(zephyr_sram)

JarmouniA · 2025-08-12T13:36:35Z

soc/st/stm32/stm32wb0x/s2ram_marking.S

+
+#define RCC_CSR			(DT_REG_ADDR(DT_NODELABEL(rcc)) + 0x94)
+#define PWR_BASE		DT_REG_ADDR(DT_NODELABEL(pwrc))
+#define PWR_SR1			0x10


Suggested change

#define PWR_SR1 0x10

#define STM32WB0_PWR_SR1 0x10

JarmouniA · 2025-08-12T13:39:15Z

drivers/bluetooth/hci/hci_stm32wb0.c

+
+#if CONFIG_PM_DEVICE
+/* ST Proprietary extended event */
+#define HCI_EXT_EVT					0x82


Suggested change

#define HCI_EXT_EVT 0x82

#define STM32_HCI_EXT_EVT 0x82

JarmouniA · 2025-08-12T13:39:57Z

drivers/bluetooth/hci/hci_stm32wb0.c

+/* ST Proprietary extended event */
+#define HCI_EXT_EVT					0x82
+#define ACI_HAL_END_OF_RADIO_ACTIVITY_VSEVT_CODE	0x0004
+#define STATE_ALL_BITMASK				0xFFFF


Suggested change

#define STATE_ALL_BITMASK 0xFFFF

#define STM32_STATE_ALL_BITMASK 0xFFFF

JarmouniA · 2025-08-12T13:40:16Z

drivers/bluetooth/hci/hci_stm32wb0.c

+#define HCI_EXT_EVT					0x82
+#define ACI_HAL_END_OF_RADIO_ACTIVITY_VSEVT_CODE	0x0004
+#define STATE_ALL_BITMASK				0xFFFF
+#define STATE_IDLE					0x00


Suggested change

#define STATE_IDLE 0x00

#define STM32_STATE_IDLE 0x00

JarmouniA · 2025-08-12T13:47:29Z

drivers/bluetooth/hci/hci_stm32wb0.c


+	/* Construct net_buf from event data */
+	buf = get_rx(buffer_out);


the NULL check should be 1st, and it should result in a panic or reset or something if it's not excepted.

Update west.yml to point to the recent changes for hal_stm32. Signed-off-by: Ali Hozhabri <[email protected]>

github-actions · 2025-08-13T08:06:40Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_stm32	zephyrproject-rtos/hal_stm32@`126cbbe`	zephyrproject-rtos/hal_stm32#303	zephyrproject-rtos/hal_stm32#303/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

sonarqubecloud · 2025-08-13T08:30:54Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

HoZHel added 7 commits August 5, 2025 16:27

drivers: Fix the improper use of CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC

0148d5a

Fix the improper use of CONFIG_SYS_CLOCK_HW_CYCLES_PER_SEC for some STM32WB0 drivers due to the misunderstanding of its definition. Signed-off-by: Ali Hozhabri <[email protected]>

drivers: timer: Provide radio timer driver for STM32WB0x SoCs

dc75210

Provide radio timer driver for STM32WB0x SoCs. Signed-off-by: Ali Hozhabri <[email protected]>

soc: st: stm32: Provide PM support for STM32WB0x

85f6d6b

Provide PM support, specifically suspend-to-ram, for STM32WB0x. Enable STM32_RADIO_TIMER Kconfig parameter when PM is set. Signed-off-by: Ali Hozhabri <[email protected]>

drivers: serial: Enable UART wake-up line in STM32

02868b7

Enable UART wake-up line in STM32 driver. Signed-off-by: Ali Hozhabri <[email protected]>

drivers: bluetooth: hci: Add PM support to the STM32WB0x HCI driver

1c30da4

Add PM support to the STM32WB0x Bluetooth HCI driver. Implement PM event register to wake up the device for its BLE events. Signed-off-by: Ali Hozhabri <[email protected]>

boards: st: nucleo_wb09ke: Optimize power consumption

68ee408

Optimize power consumption for the Nucleo-WB09KE board by implementing correct pull-up/pull-down configurations when the device enters lower power states. Signed-off-by: Ali Hozhabri <[email protected]>

HoZHel mentioned this pull request Aug 12, 2025

lib: stm32wb0: Provide support for using radio timer as the system clock zephyrproject-rtos/hal_stm32#303

Open

nordicjm requested changes Aug 12, 2025

View reviewed changes

JarmouniA requested changes Aug 12, 2025

View reviewed changes

west.yml: Update west to point to the recent changes for hal_stm32

be88807

Update west.yml to point to the recent changes for hal_stm32. Signed-off-by: Ali Hozhabri <[email protected]>

HoZHel force-pushed the PM_with_radio_timer branch from 7e53340 to be88807 Compare August 13, 2025 08:05

github-actions bot added manifest manifest-hal_stm32 DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Aug 13, 2025

	#define SRAM DT_CHOSEN(zephyr_sram)
	#define STM32WB0_SRAM DT_CHOSEN(zephyr_sram)

	#define STATE_ALL_BITMASK 0xFFFF
	#define STM32_STATE_ALL_BITMASK 0xFFFF


		/* Construct net_buf from event data */
		buf = get_rx(buffer_out);

STM32WB0x: Add PM support (suspend-to-ram) #94402

Are you sure you want to change the base?

STM32WB0x: Add PM support (suspend-to-ram) #94402

Conversation

HoZHel commented Aug 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JarmouniA Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 13, 2025

Uh oh!

sonarqubecloud bot commented Aug 13, 2025

Quality Gate passed

Uh oh!

Uh oh!

JarmouniA Aug 12, 2025 •

edited

Loading